On 07/27/2012 07:46 AM, Deepthi Dharwar wrote:
> Hi Daniel,
>
>
> On 07/25/2012 04:15 PM, Daniel Lezcano wrote:
>
>> This variable is only used in the in processor_driver.c.
>> This patch reduces the scope of the variable by moving it
>> to this file.
>>
>
>
> This is true after applying your second patch .
> Maybe you can check the sequencing of patches in the series.
> As a thumb rule one should be able to build the kernel
> by applying each and every patch in the series .
Thanks Deepthi. I think I already git bisect tested the patchset.
This patch does not break the build, the variable is defined in the
processor_driver.c file.
> There would be a build break after applying this one as
> acpi_idle_driver is still used in processor_idle.c by applying
> just this patch.
>
> Cheers,
> Deepthi
>
>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@xxxxxxxxxx>
>> ---
>> drivers/acpi/processor_driver.c | 2 +-
>> include/acpi/processor.h | 1 -
>> 2 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c
>> index 7048b97..017b39d 100644
>> --- a/drivers/acpi/processor_driver.c
>> +++ b/drivers/acpi/processor_driver.c
>> @@ -113,7 +113,7 @@ static struct acpi_driver acpi_processor_driver = {
>>
>> DEFINE_PER_CPU(struct acpi_processor *, processors);
>> EXPORT_PER_CPU_SYMBOL(processors);
>> -
>> +extern struct cpuidle_driver acpi_idle_driver;
>> struct acpi_processor_errata errata __read_mostly;
>>
>> /* --------------------------------------------------------------------------
>> diff --git a/include/acpi/processor.h b/include/acpi/processor.h
>> index db427fa..8b2c39a 100644
>> --- a/include/acpi/processor.h
>> +++ b/include/acpi/processor.h
>> @@ -332,7 +332,6 @@ int acpi_processor_power_exit(struct acpi_processor *pr,
>> struct acpi_device *device);
>> int acpi_processor_suspend(struct device *dev);
>> int acpi_processor_resume(struct device *dev);
>> -extern struct cpuidle_driver acpi_idle_driver;
>>
>> /* in processor_thermal.c */
>> int acpi_processor_get_limit_info(struct acpi_processor *pr);
>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
