Hi, 2012/7/23 Henrique de Moraes Holschuh <hmh@xxxxxxxxxx>: > On Mon, 23 Jul 2012, Matthew Garrett wrote: >> On Mon, Jul 16, 2012 at 10:27:57AM +0800, AceLan Kao wrote: >> > So, I didn't get the point why we can just remove the event, we don't rely on it >> > to enter S3 now, and to take into account that it's deprecated since >> > 2007(fb804714), >> > I don't think we should do more workaround for this. >> >> I've no objection to removing the event, I just want to know why we >> don't also need a solution in the evdev path. Why is this not a problem >> there? Actually, it will enter S3 at most 2 times through evdev path. The keyevents will be emitted at once while pressing the hotkey, the GUI(gnome-power-manager under gnome, for instance) will do the reaction. So, I think GUI will just ignore the following sleep events. And it will enter another S3 after doing input_dev_release_keys() in drivers/input/input.c +2174 during resuming if the key is not thought to be released. The big difference between evdev and proc acpi event is that proc acpi event won't send out the next event until the current one is done. We can observe its behavior by "acpi_listen" It sends out the next event after the system wakeup, so that the system will enter S3 again. I didn't dig into the code where it queues the events, I just observed it. > > Indeed. > > And if it is related _directly_ to thinkpad-acpi, please state so. Because > thinkpad-acpi does have legacy compatibility crap that can issue duplicated > events (same event over different paths: evdev, acpi procfs, acpi netlink) > but it is supposed to never do that unless actively configured to do so. This patch do nothing to thinkpad-acpi, and I have already verified that it won't damage the current behavior of thinkpad-acpi driver. > > -- > "One disk to rule them all, One disk to find them. One disk to bring > them all and in the darkness grind them. In the Land of Redmond > where the shadows lie." -- The Silicon Valley Tarot > Henrique Holschuh -- Chia-Lin Kao(AceLan) http://blog.acelan.idv.tw/ E-Mail: acelan.kaoATcanonical.com (s/AT/@/) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
