Hi, Rafael, thanks for reviewing this patch set. On 四, 2012-07-19 at 21:38 +0200, Rafael J. Wysocki wrote: > On Thursday, July 19, 2012, Zhang Rui wrote: > > From: Durgadoss R <dugardoss.r@xxxxxxxxx> > > > > Some of the thermal drivers using the Generic Thermal Framework > > require (all/some) trip points to be writeable. This patch makes > > the trip point temperatures writeable on a per-trip point basis, > > and modifies the required function call in thermal.c. This patch > > also updates the Documentation to reflect the new change. > > > > Signed-off-by: Durgadoss R <durgadoss.r@xxxxxxxxx> > > Signed-off-by: Zhang Rui <rui.zhang@xxxxxxxxx> > > --- > > Documentation/thermal/sysfs-api.txt | 4 +- > > drivers/acpi/thermal.c | 4 +- > > drivers/platform/x86/acerhdf.c | 2 +- > > drivers/platform/x86/intel_mid_thermal.c | 2 +- > > drivers/thermal/spear_thermal.c | 2 +- > > drivers/thermal/thermal_sys.c | 147 +++++++++++++++++++++--------- > > include/linux/thermal.h | 15 ++- > > 7 files changed, 125 insertions(+), 51 deletions(-) > > > > diff --git a/Documentation/thermal/sysfs-api.txt b/Documentation/thermal/sysfs-api.txt > > index 1733ab9..0c7c423 100644 > > --- a/Documentation/thermal/sysfs-api.txt > > +++ b/Documentation/thermal/sysfs-api.txt > > @@ -32,7 +32,8 @@ temperature) and throttle appropriate devices. > > > > 1.1 thermal zone device interface > > 1.1.1 struct thermal_zone_device *thermal_zone_device_register(char *name, > > - int trips, void *devdata, struct thermal_zone_device_ops *ops) > > + int trips, int flag, void *devdata, > > + struct thermal_zone_device_ops *ops) > > > > This interface function adds a new thermal zone device (sensor) to > > /sys/class/thermal folder as thermal_zone[0-*]. It tries to bind all the > > @@ -40,6 +41,7 @@ temperature) and throttle appropriate devices. > > > > name: the thermal zone name. > > trips: the total number of trip points this thermal zone supports. > > + flag: Bit string: If 'n'th bit is set, then trip point 'n' is writeable. > > devdata: device private data > > ops: thermal zone device call-backs. > > .bind: bind the thermal zone device with a thermal cooling device. > > I wonder. What is the maximum number of trip points currently passed to this > function in one call? > in include/linux/thermal.h #define THERMAL_MAX_TRIPS 12 thanks, rui -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
