On Friday, July 13, 2012, Daniel Lezcano wrote: > On 07/13/2012 02:17 AM, Konrad Rzeszutek Wilk wrote: > > On Thu, Jul 12, 2012 at 11:03:45PM +0200, Daniel Lezcano wrote: > >> Remove the power field as it is not used. > >> > > It looks to be used in drivers/xen/xen-acpi-processor.c. > > > > I could emulate some value and stick it in there.. but I am > > more curious - what is the intent of this value? > > At the first glance, this value is the power consumption of the > specified state. I am not sure all acpi returns a correct value. > > I can imagine the power should be copied to the cpuidle_state structure > to the power field where it is used by the governor to choose the better > C-state. As it is not specified, cpuidle will assume the C-State N > consumes less than the C-State N-1. > > If we want to add the power consumption we should also set the > 'power_specified' flag for the driver, but that could change the > behavior of the cpuidle driver. > > Anyway, IMO, this field is useless for this structure and should be > specified later, if that makes sense, directly in the cpuidle_state > structure like the other drivers do. > > If nobody complains, I will remove the field also from Xen and resend > this patch. Please do. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
