On Fri, 2012-07-06 at 12:02 +0900, Yasuaki Ishimatsu wrote: > Hi Toshi, > > 2012/06/29 23:51, Toshi Kani wrote: > > Added CPU hot-remove support through an ACPI eject notification. > > It calls acpi_bus_hot_remove_device(), which shares the same code > > path with the sysfs eject operation. acpi_os_hotplug_execute() > > serializes hot-remove operations between ACPI hot-remove and sysfs > > eject requests. > > > > Signed-off-by: Toshi Kani <toshi.kani@xxxxxx> > > Looks good to me. > > Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@xxxxxxxxxxxxxx> Great! Thanks Yasuaki for reviewing! -Toshi > > > > --- > > This patch applies on top of the patchset below. > > > > [PATCH v6 0/6] ACPI: Add _OST support for ACPI hotplug > > http://marc.info/?l=linux-acpi&m=134074381322973&w=2 > > > > --- > > drivers/acpi/processor_driver.c | 27 +++++++++++++++++---------- > > 1 files changed, 17 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/acpi/processor_driver.c b/drivers/acpi/processor_driver.c > > index f9fa1b2..a6f6bde 100644 > > --- a/drivers/acpi/processor_driver.c > > +++ b/drivers/acpi/processor_driver.c > > @@ -699,8 +699,8 @@ int acpi_processor_device_add(acpi_handle handle, struct acpi_device **device) > > static void acpi_processor_hotplug_notify(acpi_handle handle, > > u32 event, void *data) > > { > > - struct acpi_processor *pr; > > struct acpi_device *device = NULL; > > + struct acpi_eject_event *ej_event = NULL; > > u32 ost_code = ACPI_OST_SC_NON_SPECIFIC_FAILURE; /* default */ > > int result; > > > > @@ -732,20 +732,27 @@ static void acpi_processor_hotplug_notify(acpi_handle handle, > > "received ACPI_NOTIFY_EJECT_REQUEST\n")); > > > > if (acpi_bus_get_device(handle, &device)) { > > - printk(KERN_ERR PREFIX > > - "Device don't exist, dropping EJECT\n"); > > + pr_err(PREFIX "Device don't exist, dropping EJECT\n"); > > break; > > } > > - pr = acpi_driver_data(device); > > - if (!pr) { > > - printk(KERN_ERR PREFIX > > - "Driver data is NULL, dropping EJECT\n"); > > + if (!acpi_driver_data(device)) { > > + pr_err(PREFIX "Driver data is NULL, dropping EJECT\n"); > > break; > > } > > > > - /* REVISIT: update when eject is supported */ > > - ost_code = ACPI_OST_SC_EJECT_NOT_SUPPORTED; > > - break; > > + ej_event = kmalloc(sizeof(*ej_event), GFP_KERNEL); > > + if (!ej_event) { > > + pr_err(PREFIX "No memory, dropping EJECT\n"); > > + break; > > + } > > + > > + ej_event->handle = handle; > > + ej_event->event = ACPI_NOTIFY_EJECT_REQUEST; > > + acpi_os_hotplug_execute(acpi_bus_hot_remove_device, > > + (void *)ej_event); > > + > > + /* eject is performed asynchronously */ > > + return; > > > > default: > > ACPI_DEBUG_PRINT((ACPI_DB_INFO, > > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
