Re: [PATCH V5 5/8] usb/acpi: add check for the connect type of usb port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 29 Jun 2012, Lan Tianyu wrote:

> Change since v4: Remove some redundant kerneldocs and fix typo.
> 
> Change since v3: Rebase on the patch "make usb port a real device"
> 
> Check the connect type of usb port when getting the usb port's
> acpi_handle and store result into connect_type in the struct
> usb_port.
> 
> Accoding to ACPI Spec 9.13. PLD indicates whether usb port is
> user visible and _UPC indicates whether it is connectable. If
> the port was visible and connectable, it could be freely connected
> and disconnected with USB devices. If no visible and connectable,
> a usb device is directly hard-wired to the port. If no visible and
> no connectable, the port would be not used.
> 
> When a device was found on the port, if the connect_type was hot-plug,
> then the device would be removable. If the connect_type was hard-wired,
> the device would be non-removable.
> 
> Signed-off-by: Lan Tianyu <tianyu.lan@xxxxxxxxx>

> +/**
> + * usb_get_hub_port_connect_type - Get the port's connect
> + * type

Don't break the line like that.

> + * @hdev: USB device belonging to the usb hub
> + * @port1: port num of the port
> + *
> + * Return connect type of the port and if input params are
> + *	invalid, return USB_PORT_CONNECT_TYPE_UNKNOWN.
> + */
> +enum usb_port_connect_type
> +usb_get_hub_port_connect_type(struct usb_device *hdev,	int port1)

Tab instead of a space.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux