Hi Eduardo, > > + Enable this to manage platform thermals using a simple linear > > + throttling algorithm > > Same as before, add some description of the governor-policy. I added comments while defining this function inside the file. Never mind, will make it more readable in next version :-) > > + else if (new_state <= 0) > > new_state can not be negative as it is declared as unsigned. Good one. Thank you. will fix. > > Again, what was the difference between linear and step_wise? > Not intended to be different. > Is it so that linear applies only to the passive trip points and > step wise applies to all cooling devices in the specific zone? No. Right now it is like that. Now that we agree to clean thermal_sys.c from throttling code, I will add that functionality here. > > I guess we need some more clarity on the differences. I hope my next patch set will make things clear. Thanks, Durga -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html