On Wed, 2012-05-09 at 12:16 -0600, Toshi Kani wrote: > > > > > > Added macro definitions of _OST source events and status codes. > > > Also renamed OSC_SB_CPUHP_OST_SUPPORT to OSC_SB_HOTPLUG_OST_SUPPORT > > > since this _OSC bit is not specific to CPU hotplug. This bit is > > > defined in Table 6-147 of ACPI 5.0 as follows. Sorry. Missed that. It was in patch 7. Any reason why this feature is split across 7 patches? Might be better to combine patches 1, 2, and 7 as it contains the infrastructure type code for _OST. Something to consider. There is no functional change with this patch set in the sense that _OST doesn't get evaluated on platforms that don't support _OST, however there is run-time change on all architectures with patches 3, 4, and 5. There are couple of new kfree() calls introduced. Something to take a closer to make sure it is safe in that path. Also, what missing functionality does evaluating _OST add to the kernel? What happens if OS continues to not evaluate _OST? It is an optional method, looking for what is the value add? -- Shuah -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
