On Wed, Apr 25, 2012 at 01:49:40PM +0100, Alan Cox wrote: > On Wed, 25 Apr 2012 13:40:18 +0100 > Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > > No you don't - there's various platforms that will hang if you do that. > > It's necessary to make sure that the DIDL fields are set up before > > calling any ACPI video functions on opregion hardware. > > Then the existing driver code is already broken, because it ifdefs out > the check if i915 is not compiled for the kernel. Yes, that does seem broken. I'm fine with just removing the #ifdefs and adding the i740 check. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html