Hello Joe, On Fri, Mar 30, 2012 at 12:08:50PM -0700, Joe Perches wrote: > On Fri, 2012-03-30 at 16:41 +0300, Eduardo Valentin wrote: > > On Fri, Mar 30, 2012 at 06:13:20AM -0400, Len Brown wrote: > > > From: Joe Perches <joe@xxxxxxxxxxx> > > > Use the current logging style. > [] > > We should get the struct dev in thermal_zone_device, I think it makes > > more sense to use the dev_* helper functions. > [] > > The orig argument could probably be changed to a thermal zone device > > and the we use it's id as orig for the message. > > What do you think? > > dev_<level> should be used instead of pr_<level> when > an appropriate struct device * is available. Agreed that we need a struct device *. My comments are based on the fact that you have one of it inside the struct therma_zone_device, field device. Isn't that struct device appropriated enough to be used by the dev_* functions? > > cheers, Joe > Cheers, Eduardo -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
