Re: [PATCH] ACPI, APEI: Add validation check before GHES error is recorded

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



于 2012/3/30 1:07, Luck, Tony 写道:
+	if (mem_err->validation_bits&  CPER_MEM_VALID_PHYSICAL_ADDRESS)
+		m.addr = mem_err->physical_addr;

At the moment "addr" is the only useful value in this record ... so
if we find that we can't supply it because we don't know it - then the
record has no value, and we might as well not send it.

E.g. start the function with:

	if (!(mem_err->validation_bits&  CPER_MEM_VALID_PHYSICAL_ADDRESS))
		return;

-Tony

But as Ying said before, in theory we need to support this scenario, otherwise, I prefer to
add check condition out of this function, not here.

What's your opinion, Ying?
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux