On Tue, Mar 20, 2012 at 05:28:06PM +0100, Corentin Chary wrote: > On Tue, Mar 20, 2012 at 5:05 PM, Matthew Garrett <mjg59@xxxxxxxxxxxxx> wrote: > > Are the hotkeys delivered via ACPI or via the Samsung device? If the > > latter, you can just do unregister_acpi_video() instead in the samsung > > driver and avoid having more machine-specific quirks in the ACPi code. > > I wasn't aware of acpi_video_unregister(). The issue with that > solution is that it makes it harder to respect acpi_video= parameter. > > On these machines, the ACPI Video device is broken (I don't know how, > I don't have the hardware, I just know it doesn't work at all), and I > want the default to be acpi_backlight=vendor, but it is still a good > idea to let users force acpi_backlight=video. If it's broken then I don't think there's a great argument for providing an argument just to let people re-break their kernel :) > But if the policy is to use acpi_video_unregister() when the video > module is known to be broken, let's do that. As long as ACPI isn't being used to deliver brightness keys, then this is fine. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
