Hi Matthew, 於 一,2012-03-19 於 13:31 +0000,Matthew Garrett 提到: > On Mon, Mar 19, 2012 at 02:03:47PM +0800, Lee, Chun-Yi wrote: > > > diff --git a/drivers/acpi/video_detect.c b/drivers/acpi/video_detect.c > > index f3f0fe7..acb15d6 100644 > > --- a/drivers/acpi/video_detect.c > > +++ b/drivers/acpi/video_detect.c > > @@ -132,6 +132,32 @@ find_video(acpi_handle handle, u32 lvl, void *context, void **rv) > > return AE_OK; > > } > > > > +static int video_set_backlight_vendor(const struct dmi_system_id *d) > > +{ > > + acpi_video_support |= ACPI_VIDEO_BACKLIGHT_DMI_VENDOR; > > + return 0; > > +} > > + > > +static const struct dmi_system_id video_vendor_dmi_table[] = { > > + { > > + .callback = video_set_backlight_vendor, > > + .ident = "Acer Aspire 4736", > > + .matches = { > > + DMI_MATCH(DMI_BOARD_VENDOR, "Acer"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 4736"), > > + }, > > + }, > > + { > > + .callback = video_set_backlight_vendor, > > + .ident = "Acer TravelMate 4750", > > + .matches = { > > + DMI_MATCH(DMI_BOARD_VENDOR, "Acer"), > > + DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"), > > + }, > > + }, > > + {} > > +}; > > + > > I think it would be neater to put this in the Acer driver and have it > call unregister_acpi_video(). > Thanks for your review and suggestion. I will send out a new patch for acer-wmi. Thanks a lot! Joey Lee -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html