On Wed, Mar 07, 2012 at 03:02:47PM +0100, Rainer Koenig wrote:
> + if (strncasecmp(quickstart->btn->name, "ODDE", 4) == 0) {
> + /* ODDE is Optical Disc Drive Eject */
> + quickstart_data.pressed = quickstart->btn;
> + }
This is wrong. Since the GHID method returns an arbitrary
vendor-specific value, you should just make sure that there's
appropriate keymap remapping support and then provide a udev fragment
that does the appropriate GHID->keycode assignment. Also, you really do
need to report this as KEY_CDEJECT - it's not acceptable to require an
acpid script.
--
Matthew Garrett | mjg59@xxxxxxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
