On Tue, 2012-02-28 at 16:44 +0800, Chen Gong wrote:
> On the platforms with ACPI4.x support, parameter extension
> is not always doable, which means only parameter extension
> is enabled, einj_param can take effect.
>
> Signed-off-by: Chen Gong <gong.chen@xxxxxxxxxxxxxxx>
> ---
> drivers/acpi/apei/einj.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/acpi/apei/einj.c b/drivers/acpi/apei/einj.c
> index 4ca087d..0323684 100644
> --- a/drivers/acpi/apei/einj.c
> +++ b/drivers/acpi/apei/einj.c
> @@ -466,7 +466,7 @@ static int __einj_error_inject(u32 type, u64 param1, u64 param2)
> rc = apei_exec_run(&ctx, ACPI_EINJ_SET_ERROR_TYPE);
> if (rc)
> return rc;
> - if (einj_param) {
> + if (param_extension && einj_param) {
> struct einj_parameter *v4param = einj_param;
> v4param->param1 = param1;
> v4param->param2 = param2;
Good catch! It appears that is introduced when adding ACPI 5.0
parameter support. Or we can fix einj_get_parameter_address() to return
NULL if param_extension is 0 and paddrv5 is 0.
Best Regards,
Huang Ying
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
