> Suggest to reset the notrigger flag to default value (zero) after the injection > operation, so the test script doesn't need to explicitly set the notrigger flag > for each injection operation and it's backward compatible with existing scripts. > It would be better to reset the param2 too for the same reason. That might cause more confusion. We haven't documented the behavior of the other files here after an error is injected ... but their actual behavior has always been that values written are sticky. I.e. you can write a script to inject three errors to the same page like this: echo 0x8 > error_type echo 0x12340000 > param1 echo 0xfffffffffffff000 > param2 echo 1 > error_inject sleep 1 echo 1 > error_inject sleep 1 echo 1 > error_inject so I think that it might be surprising if "notrigger" was not sticky like everything else. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
