On Mon, Feb 13, 2012 at 7:52 AM, Jiang Liu <liuj97@xxxxxxxxx> wrote: > The function apei_estatus_print() and apei_estatus_check() forget to move ahead > the gdata pointer when dealing with multiple generic error data sections. > > Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxx> > --- > drivers/acpi/apei/cper.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/drivers/acpi/apei/cper.c b/drivers/acpi/apei/cper.c > index 5d41894..e6defd8 100644 > --- a/drivers/acpi/apei/cper.c > +++ b/drivers/acpi/apei/cper.c > @@ -362,6 +362,7 @@ void apei_estatus_print(const char *pfx, > gedata_len = gdata->error_data_length; > apei_estatus_print_section(pfx, gdata, sec_no); > data_len -= gedata_len + sizeof(*gdata); > + gdata = (void *)(gdata + 1) + gedata_len; > sec_no++; > } > } > @@ -396,6 +397,7 @@ int apei_estatus_check(const struct acpi_hest_generic_status *estatus) > if (gedata_len > data_len - sizeof(*gdata)) > return -EINVAL; > data_len -= gedata_len + sizeof(*gdata); > + gdata = (void *)(gdata + 1) + gedata_len; > } > if (data_len) > return -EINVAL; > -- Thanks for splitting this into separate patches. While you're at it, please make the subject lines specific and meaningful. "Fix bug" is not useful to someone examining the changelogs looking for a specific issue or deciding whether the change needs to be backported into a distro. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
