Hi,
Please ignore my previous mail, my mailer wrongly formatted
it with html tags and it got filtered out from the lists.
Firstly: This has to get in quickly if it shouldn't miss
3.3 (again). Tiny adjustings (I don't see any, beside the
issue Bjorn brought up) can still be done later, but I
guess this rather big one gets rejected by Linus after
the merge window closed.
Here again:
On Saturday, January 21, 2012 09:38:27 PM Bjorn Helgaas wrote:
> +cc Tony, linux-ia64
>
...
> >> {
> >> @@ -353,7 +385,7 @@ acpi_os_map_memory(acpi_physical_address phys, acpi_size size)
> >>
> >> pg_off = round_down(phys, PAGE_SIZE);
> >> pg_sz = round_up(phys + size, PAGE_SIZE) - pg_off;
> >> - virt = acpi_os_ioremap(pg_off, pg_sz);
> >> + virt = acpi_map(pg_off, pg_sz);
Ok, that worked before, also on IA64.
That means that typically/normally/always io mem is tried to be mapped.
It's due to the new APEI infrastructure/features that ram could
get mapped via acpi_os_map_memory.
Is there any Itanium out there implementing any APEI table?
Will there ever be one?
Even if, isn't it a BIOS bug if such stuff is declared in ram and not
in reserved memory (also on X86)?
Especially on an Enterprise Itanium platform,
I guess the vendor should or better has to fix it up.
I'd do:
can_use_ioremap(pfn) instead of should_use_kmap(pfn)
and let it return false in ram + ia64 case, something like:
#ifdef IA64
#define can_use_ioremap(pfn) !page_is_ram(pfn)
#endif
Pass the error upwards and APEI should get disabled on IA64,
if any ACPI code tries to ioremap real memory early (when
the APEI table parsing happens).
A nice FW_BUG message could be added as well (also on X86?).
Don't forget to use:
iounmap(vaddr);
only in acpi_unmap() then.
FWIW I even grepped for APEI tables on the most recent IA
machine we have -> no APEI tables.
If the rest is functionally the same as the patch series
you've send some months ago, feel free to add:
Reviewed-by: Thomas Renninger <trenn@xxxxxxx>
I had a rather close look at those patches.
Thomas
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
