On Wed, Jan 11, 2012 at 01:18:05AM -0600, Robert Lee wrote: > Add thermal support for i.MX6Q. Uses recently submitted common > cpu_cooling functionality shown here: > > http://www.spinics.net/lists/linux-pm/msg26500.html > > Have some todo items but basic implementation is done and I'd like to > get any helpful feedback on it. Generally shouldn't this be a regular driver? > + > +/* register define of anatop */ > +#define HW_ANADIG_ANA_MISC0 (0x00000150) > +#define HW_ANADIG_ANA_MISC0_SET (0x00000154) > +#define HW_ANADIG_ANA_MISC0_CLR (0x00000158) > +#define HW_ANADIG_ANA_MISC0_TOG (0x0000015c) unnecessary braces. Please remove. > + > +#if IMX6Q_THERMAL_DEBUG > + pr_info("Temperature is %lu C\n", *temp); > +#endif Please don't add your own debug defines which then issue messages with pr_info. Use pr_debug in the first place. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
