On 01/11/2012 05:18 AM, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Yanmin Zhang <yanmin_zhang@xxxxxxxxxxxxxxx>
> Subject: drivers/idle/intel_idle.c: remove redundant local_irq_disable() call
>
> irq disabling happens earlier in process_32.c:cpu_idle. Basically,
> cpuidle_state->enter is called, cpu irq is disabled. cpuidle_state->enter
> would turn on irq when exiting.
>
> intel_idle doesn't follow this assumption. Although it doesn't cause real
> issue, it misleads developers. Remove the call to local_irq_disable() at
> entry.
>
> [akpm@xxxxxxxxxxxxxxxxxxxx: add comment]
> Signed-off-by: mzha38X <mingmingx.zhang@xxxxxxxxx>
^^^^^^^
Are nicknames acceptable? AFAIK, real names are preferred...
> Cc: "Li, Shaohua" <shaohua.li@xxxxxxxxx>
> Cc: "Brown, Len" <len.brown@xxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
Regards,
Srivatsa S. Bhat
IBM Linux Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
