Re: 'flags' in rsparser.c change from 'register disabled resources' patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

your observation is correct. In fact, the patch can be simplified by not setting the IORESOURCE_DISABLED flag at all, which is functionally equivalent to the current state where the compiler removes this value because it cannot be assigned to a char. A quick compare of the generated code of the current version (with IORESOURCE_DISABLED included) and with IORESOURCE_DISABLED not used at all yields pretty much the same code.

I realized the problem only days after I submitted my patch. Apparently, a follow-up patch which takes care of the IORESOURCE_DISABLED flags did not make it into the mainline kernel. I'll resend it as a response to this post shortly. In addition, in https://lkml.org/lkml/2011/7/31/50 I submitted a much simpler version of the patch which better exposes the change it introduces but requires 29df8d8f8702f0f53c1375015f09f04bc8d023c1 to be reverted.

--- Witold
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux