Re: [PATCH] ACPI, APEI, Print resource errors in conventional format

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 28, 2011 at 6:49 PM, Huang Ying <ying.huang@xxxxxxxxx> wrote:
> On 08/27/2011 01:10 AM, Bjorn Helgaas wrote:
>> Use the normal %pR-like format for MMIO and I/O port ranges.
>>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
>> ---
>>  drivers/acpi/apei/apei-base.c |    8 ++++----
>>  1 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/acpi/apei/apei-base.c b/drivers/acpi/apei/apei-base.c
>> index 8041248..8bd5f1a 100644
>> --- a/drivers/acpi/apei/apei-base.c
>> +++ b/drivers/acpi/apei/apei-base.c
>> @@ -460,9 +460,9 @@ int apei_resources_request(struct apei_resources *resources,
>>                                      desc);
>>               if (!r) {
>>                       pr_err(APEI_PFX
>> -             "Can not request iomem region <%016llx-%016llx> for GARs.\n",
>> +             "Can not request [mem %#010llx-%#010llx] for %s registers\n",
>
> Why %#010llx instead of %#016llx?

Because %#010llx is effectively what we use for %pR.  Two characters
for "0x", then eight for the value.  IMHO, sixteen uninterrupted hex
characters is too hard to read.

Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux