On Tue, Jun 21, 2011 at 03:16:27PM +0800, Huang Ying wrote: > + rc = apei_osc_setup(); > + if (rc) > + pr_info(GHES_PFX "Evaluate APEI _OSC failed!\n"); Hm. This is maybe a little strong. It'd be valid for a machine to return an error here but still have the GHES functionality enabled via the generic call, but this message would still show up and potentially confuse the user. Can we keep a flag to check whether the generic method gave us control, and only give the error if both fail to enable it? -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html