Re: bug in acer-wmi.c, wmid3_set_device_status(), initialization of params.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Joern, 

æ äï2011-05-31 æ 15:03 +1200ïJoern Heissler æåï
> Hello,
> 
> I think I have found a bug in acer-wmi.c,
> commit 987dfbaa65b2c3568b85e29d2598da08a011ee09:
> 
> The function wmid3_set_device_status contains:
> 
>     struct wmid3_gds_input_param params = {
>         .function_num = 0x1,
>         .hotkey_number = 0x01,
>         .devices = ACER_WMID3_GDS_WIRELESS &
>                 ACER_WMID3_GDS_THREEG &
>                 ACER_WMID3_GDS_WIMAX &
>                 ACER_WMID3_GDS_BLUETOOTH,
>     };
> 
> (1<<0) & (1<<6) & (1<<7) & (1<<11) is zero. Meant bitwise or?
> 

OK, it's my mistake, must be OR but not AND.
I will generate a fix patch, I will test it again, please kindly help
test it later.

> And could someone please update the driver to support my laptop?
> See https://bugzilla.kernel.org/show_bug.cgi?id=36322 for details :-)
> 
> Cheery
> Joern Heissler

I will take look at.


Thank's
Joey Lee

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux