On Fri, 1 Apr 2011 17:44:46 +0200 Florian Mickler <florian@xxxxxxxxxxx> wrote: > > Hi Ingo, > > Instead of exporting find_irq_entry, irq_trigger and irq_polarity, I added a > new helper function 'ioapic_get_irq(..)' and exported that. > > Also I did it as a seperate commit, since it is more of a cleanup and the other > commit is already tested... hope this is ok. > > Regards, > Flo > btw, include/linux/acpi.h: 120 121 #ifdef CONFIG_X86_IO_APIC 122 extern int acpi_get_override_irq(u32 gsi, int *trigger, int *polarity); 123 #else 124 #define acpi_get_override_irq(gsi, trigger, polarity) (-1) 125 #endif this shouldn't be needed anymore, as acpi_get_override_irq is now independent of CONFIG_X86_IO_APIC (because of ioapic_get_irq having a placeholder in the !CONFIG_X86_IO_APIC case) But on the other hand, the code flow for the !CONFIG_X86_IO_APIC would be kind of silly... what's the rationale for mp_find_ioapic returning 0 in the !CONFIG_X86_IO_APIC case? And how do I check compilation of !CONFIG_X86_IO_APIC? It looks like it already has problems, as mp_find_ioapic_pin is not stubbed out, or am I overlooking something? Regards, Flo -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
