On Tuesday, March 29, 2011, Thomas Renninger wrote: > On Tuesday 29 March 2011 21:36:50 Rafael J. Wysocki wrote: > > On Tuesday, March 29, 2011, Thomas Renninger wrote: > > > With /sys/kernel/debug/acpi/custom_method root can write > > > to arbitrary memory and increase his priveleges, even if > > > these are restricted. > > > > > > -> Make this an own debug .config option and warn about the > > > security issue in the config description. > > > > > > -> Still keep acpi/debugfs.c which now only creates and empty > > > /sys/kernel/debug/acpi directory. There might be other > > > users of it later. > > > > > > Signed-off-by: Thomas Renninger <trenn@xxxxxxx> > > > CC: Rafael J. Wysocki <rjw@xxxxxxx> > > > CC: lenb@xxxxxxxxxx > > > CC: rui.zhang@xxxxxxxxx > > > CC: linux-acpi@xxxxxxxxxxxxxxx > > > > OK, but you don't need to move custom_method to a separate file. Why > > are you doing that, exactly? > Because there may come other acpi debugfs stuff added there and then > it either needs ugly #ifdef logics inside the file or the split will be done then. > Separating the code belonging to this option into an own > file looks like the cleanest way to me. Well, I don't really expect anything else to depend on CONFIG_ACPI_CUSTOM_METHOD, or if it does, the options should be called differently, right? Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
