Re: [PATCH]: cpufreq: pcc-cpufreq: don't load driver if get_freq fails during init.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 09, 2011 at 05:09:40PM +0100, Thomas Renninger wrote:
> Good catch.
> 
> On Wednesday, March 09, 2011 03:02:49 PM Naga Chumbalkar wrote:
> > 
> > Return 0 on failure. This will cause the initialization of the driver
> > to fail and prevent the driver from loading if the BIOS cannot handle
> > the PCC interface command to "get frequency". Otherwise, the driver
> > will load and display a very high value like "4294967274" (which is
> > actually -EINVAL) for frequency:
> > 
> > # cat /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_cur_freq
> > 4294967274
> > 
> > Signed-off-by: Naga Chumbalkar <nagananda.chumbalkar@xxxxxx>
> Reviewed-by: Thomas Renninger <trenn@xxxxxxx>
> 
> While this is not a regression, it's an easy fix.
> It should make sense to add:
> CC: stable@xxxxxxxxxx
> ?

Yes you should :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux