On Sunday, January 16, 2011, Jesper Juhl wrote:
> We will leak the memory allocated to 'local_gpe_event_info' if
> 'acpi_ut_acquire_mutex()' fails or if 'acpi_ev_valid_gpe_event()' fails in
> drivers/acpi/acpica/evgpe.c::acpi_ev_asynch_execute_gpe_method().
>
> Signed-off-by: Jesper Juhl <jj@xxxxxxxxxxxxx>
Good catch! How did you find it?
Reviewed-by: Rafael Wysocki <rjw@xxxxxxx>
Len, please apply and push to Linus ASAP.
Thanks,
Rafael
> ---
> evgpe.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/acpica/evgpe.c b/drivers/acpi/acpica/evgpe.c
> index 7c339d3..b6de1fb 100644
> --- a/drivers/acpi/acpica/evgpe.c
> +++ b/drivers/acpi/acpica/evgpe.c
> @@ -471,6 +471,7 @@ static void ACPI_SYSTEM_XFACE acpi_ev_asynch_execute_gpe_method(void *context)
>
> status = acpi_ut_acquire_mutex(ACPI_MTX_EVENTS);
> if (ACPI_FAILURE(status)) {
> + ACPI_FREE(local_gpe_event_info);
> return_VOID;
> }
>
> @@ -478,6 +479,7 @@ static void ACPI_SYSTEM_XFACE acpi_ev_asynch_execute_gpe_method(void *context)
>
> if (!acpi_ev_valid_gpe_event(gpe_event_info)) {
> status = acpi_ut_release_mutex(ACPI_MTX_EVENTS);
> + ACPI_FREE(local_gpe_event_info);
> return_VOID;
> }
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
