> if (error_block_length > GHES_ESTATUS_MAX_SIZE) {
>- pr_warning(FW_WARN GHES_PFX
>- "Error status block length is too long: %u for "
>- "generic hardware error source: %d.\n",
>+ pr_warning(
>+FW_WARN GHES_PFX "Error status block length is too long: %u for \n"
>+"generic hardware error source: %d.\n",
> error_block_length, generic->header.source_id);
> error_block_length = GHES_ESTATUS_MAX_SIZE;
Hi Ying,
I assume that you are tweaking these pr_warning() lines
to beautify the output, but as far as source
code readability, I liked the previous syntax better.
Although maintainer's opinions vary, I generally do not
strictly enforce the 80 column rule for printk strings.
Ie. I think that code readability with good whitespace
indentation plus printk string grep-ability are more
important than strictly fitting within 80-columns.
thanks,
Len Brown, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
