Re: [PATCH] ACPI: use ioremap_cache()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/27/2010 11:42 AM, Tony Luck wrote:
> On Fri, Dec 17, 2010 at 12:08 AM, Len Brown <lenb@xxxxxxxxxx> wrote:
>> No change on ia64.
> 
> Apart from breaking the build :-(
> 
>> +++ b/arch/ia64/include/asm/io.h
>    ...
>> +static inline void __iomem * ioremap_cache (unsigned long phys_addr, unsigned long size)
>> +{
>> +       return ioremap(unsigned long phys_addr, unsigned long size);
>> +}
> 
> Cut & paste issue? ... the compiler would be a lot happier
> without the "unsigned long"s in the call to ioremap().
> 

LOL...

In the long(er) run it might be worth considering having the same policy
on IA64 as on x86 -- ioremap() meaning ioremap_nocache().

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux