On Tue, Dec 21, 2010 at 7:41 PM, Jan FÃsting <jan.fuesting@xxxxxx> wrote: > Fixed some coding style issues in fan.c and battery.c > Which kind of coding style issues you have fixed? Looking at the diff I couldn't figure out the *issues* as described in the commit message. Care to resend describing which coding style issues you are fixing? Also the diff shows a change only in batter.c. Did you forget something (fan.c) ? Thanks. Ah, another thing, you have repeated the subject in the commit message, if they almost the same except the ACPI, then no need to repeat it in the commit message. > Signed-off-by: Jan FÃsting <jan.fuesting@xxxxxx> > --- > Âdrivers/acpi/battery.c | Â Â2 +- > Â1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c > index 16fc4df..35d0c6f 100644 > --- a/drivers/acpi/battery.c > +++ b/drivers/acpi/battery.c > @@ -580,7 +580,7 @@ static void acpi_battery_quirks(struct acpi_battery *battery) > Â{ > Â Â Â Âif (dmi_name_in_vendors("Acer") && battery->power_unit) > Â Â Â Â Â Â Â Âset_bit(ACPI_BATTERY_QUIRK_SIGNED16_CURRENT, &battery->flags); > -} > +} > > Â/* > Â* According to the ACPI spec, some kinds of primary batteries can > -- > 1.7.2.3 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at Âhttp://vger.kernel.org/majordomo-info.html > Please read the FAQ at Âhttp://www.tux.org/lkml/ > -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html