On Wed, 2010-11-17 at 00:38 +0800, Linus Torvalds wrote: > On Tue, Nov 16, 2010 at 3:49 AM, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > > On Tue, 2010-11-16 at 08:53 +0800, Huang Ying wrote: > >> Hi, Len, > >> > >> This patchset is needed by APEI support. Which involves some lockless > >> operations. And I think they can be used by some other part of kernel > >> too. > > > > The whole notion of allocating memory from NMI context seems incredibly > > offensive. > > > > And then there's the whole point of not merging stuff without a user. > > So I do agree that people should look very hard at trying to use > existing infrastructure. > > I kind of like the lock-less list implementation (it could easily be > useful for random things, and it's very simple). And I don't think the > notion of a lockless memory allocator is wrong either, although it > looks a lot more specialized than the list thing (the solution to > lockless allocations is generally simply to do them ahead of time). Yes. The general solution is that. But lockless memory allocator has some advantages too for some situations. For example, the memory pool backing lockless memory allocator can be enlarged or shrunken (not implemented yet) when needed. That is hard for pre-allocation. > So the part I'm really not all that comfy with is the whole APEI side > of things. I'm not at all convinced that we want yet another random > hw-specific interface, and I really have yet to hear why it's so > magical. Yes. Random hardware-specific interface is not good. In fact we have a generic hardware error reporting infrastructure that can be used by Machine Check, EDAC, PCIe AER, APEI, etc in the original patchset as follow: http://lkml.org/lkml/2010/10/27/23 http://lkml.org/lkml/2010/10/27/18 But it seem that nobody want to take a look at it. I will re-post the generic hardware error reporting infrastructure patchset with better description separately. Hope somebody will take a look at it this time. Best Regards, Huang Ying -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
