Re: [PATCH] thermal: make ops constant

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2010-11-12 at 18:20 +0800, Alan Cox wrote:
> On Fri, 12 Nov 2010 08:24:57 +0800
> Zhang Rui <rui.zhang@xxxxxxxxx> wrote:
> 
> > On Thu, 2010-11-11 at 23:27 +0800, Alan Cox wrote:
> > > From: Alan Cox <alan@xxxxxxxxxxxxxxx>
> > > 
> > > And while
> > 
> > >  touching that function definition
> > 
> > agreed.
> > 
> > >  do something about the disaster of formatting there.
> > > 
> > well. this is what we got after running Lindent.
> > Your changes are reverted If I apply your patch and run Lindent again.
> > So maybe this is a problem that should be fixed in Lindent?
> 
> Lindent is just a script for indent which is designed to help a human not
> replace them. It's not something to run automatically over code as it
> makes bad mistakes now and then.
> 
Oh, I used to run it first when a new file is introduced, although the
result doesn't look quite good for me sometimes.
Thanks for the correction.

thanks,
rui


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux