Re: [PATCH] ACPI: Make Embedded Controller command timeout delay configurable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 21 Oct 2010, Rafael J. Wysocki wrote:

> On Thursday, October 21, 2010, Thomas Renninger wrote:
> > Here and then there show up machines which need higher timeout values.
> > Finding this on affected machines can be cumbersome, because
> > ACPI_EC_DELAY is a compile option -> make it configurable via boot param.
> 
> I think the users should not be allowed to decrease the delay below certain
> reasonable limit (perhaps current value of ACPI_EC_DELAY).
> 
> > This can even be provided writable at runtime via:
> > /sys/modules/acpi/parameters/ec_delay
> 
> Would it be safe?

It is no less safe than the other sysfs knobs
that root can turn to hose the machine.

if we were concerned about the modparam becoming
a run-time API, we could make it boot-time only
and only readable at run-time.

At the moment I'm very concerned about the number of EC bugs,
and so in general I'm delighted to see knobs to help debug.

cheers,
Len Brown, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux