Re: [PATCH] ACPI: invoke DSDT corruption workaround on all Toshiba Satellite

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 29 Sep 2010 14:32:29 -0400 (EDT), Len Brown <lenb@xxxxxxxxxx>
wrote :

> From: Len Brown <len.brown@xxxxxxxxx>
> 
> Our list of Toshiba Satellite models that require this workaround
> is growing -- so invoke the workaround for the entire product line.
> 
> https://bugzilla.kernel.org/show_bug.cgi?id=14679
> 
> Signed-off-by: Len Brown <len.brown@xxxxxxxxx>
> ---
> 
> Please test this patch.
> thanks,
> -Len
> 
>  drivers/acpi/bus.c |   14 +++-----------
>  1 files changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 5c221ab..a70ca8e 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -80,23 +80,15 @@ static int set_copy_dsdt(const struct dmi_system_id *id)
>  
>  static struct dmi_system_id dsdt_dmi_table[] __initdata = {
>  	/*
> -	 * Insyde BIOS on some TOSHIBA machines corrupt the DSDT.
> +	 * Invoke DSDT corruption work-around on all Toshiba Satellite.
>  	 * https://bugzilla.kernel.org/show_bug.cgi?id=14679
>  	 */
>  	{
>  	 .callback = set_copy_dsdt,
> -	 .ident = "TOSHIBA Satellite A505",
> +	 .ident = "TOSHIBA Satellite",
>  	 .matches = {
>  		DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
> -		DMI_MATCH(DMI_PRODUCT_NAME, "Satellite A505"),
> -		},
> -	},
> -	{
> -	 .callback = set_copy_dsdt,
> -	 .ident = "TOSHIBA Satellite L505D",
> -	 .matches = {
> -		DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
Isn't that a bit too broad? Maybe we should keep "TOSHIBA" in case
another vendor decides to add "Satellite" in its DMI product name.

> -		DMI_MATCH(DMI_PRODUCT_NAME, "Satellite L505D"),
> +		DMI_MATCH(DMI_PRODUCT_NAME, "Satellite"),
>  		},
>  	},
>  	{}

Anyway, this works well on Toshiba Satellite C650D.

Tested-by: Anisse Astier <anisse@xxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux