On Sun, Sep 19, 2010 at 11:00:33AM +0800, Huang Ying wrote: > diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c > index 343168d..1a3508a 100644 > --- a/drivers/acpi/apei/hest.c > +++ b/drivers/acpi/apei/hest.c > @@ -137,20 +137,23 @@ static int hest_parse_ghes_count(struct acpi_hest_header *hest_hdr, void *data) > > static int hest_parse_ghes(struct acpi_hest_header *hest_hdr, void *data) hest_hdr is a local variable on the stack. > + > + rc = platform_device_add_data(ghes_dev, &hest_hdr, sizeof(void *)); > + if (rc) > + goto err; Now you put the address of that local variable in some global data structure. And then you likely return and later the access accesses random stack space? -Andi -- ak@xxxxxxxxxxxxxxx -- Speaking for myself only. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
