On 09/17/2010 06:56 AM, Bjorn Helgaas wrote: > On Friday, September 17, 2010 01:21:56 am Yinghai Lu wrote: >> On 09/13/2010 10:28 AM, Bjorn Helgaas wrote: >>> On Friday, September 10, 2010 08:06:26 pm Yinghai Lu wrote: >>> >>> I timed the original on a 64-CPU box where the namespace walk cost >>> should be relatively high, and the walk you added takes about 0.01 >>> seconds. The one already there took about 0.03 seconds, so neither >>> costs very much. >>> >>> And I don't like the fact that the patch below changes the ACPI CA >>> and it only partly implements acpi_get_devices(), since it ignores >>> _CID and _STA. >> >> please check this one. it still keep _STA etc. > > I think you missed this line in my previous response: > >>> But I do see your point, and having seen the patch >>> below, I prefer the original one-line version. > > The patch below is better, because it doesn't reimplement quite > so much stuff, but it still changes the CA, not sure. > and I think the end > result is still quite confusing to read. yeah, it is confusing to read.... callback with callback. > > So I still prefer the original one-line version. ok, Will resend out original one with updated changelog. Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
