On Tue, Aug 24, 2010 at 03:58:03PM +0100, Matthew Garrett wrote: > On Tue, Aug 24, 2010 at 07:51:30AM -0700, Greg KH wrote: > > On Tue, Aug 24, 2010 at 03:22:19PM +0100, Matthew Garrett wrote: > > > Erm. Sorry about that - I just realised that there's actually a fairly > > > significant problem with it :) Right now you'll perform the register > > > call unconditionally on module load. You need to make sure that there's > > > actually Poulsbo hardware in the system, either by registering as a > > > proper PCI driver and calling acpi_video_register in your probe function > > > (and unregister in your remove function) or walking the PCI device list > > > looking for a psb device. > > > > Ick, don't walk the pci device list, just register a "real" pci device > > and do it that way, it's much simpler and plays nicer with the driver > > model and the rest of the kernel. > > My only concern with that (and it's not a strong one) is that it'll > block the psb driver from binding. Of course, the psb driver should be > doing the acpi handling itself anyway, so... If a system really does have this type of driver on it, it can unbind this driver and then bind itself, from userspace, so I don't see a problem with this. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
