On Friday, August 06, 2010, Hidetoshi Seto wrote: > Rafael, > > I found that following 2 hunks break kernel build with O= option. > > (2010/08/03 6:56), Rafael J. Wysocki wrote: > > Index: linux-2.6/drivers/pci/pcie/Makefile > > =================================================================== > > --- linux-2.6.orig/drivers/pci/pcie/Makefile > > +++ linux-2.6/drivers/pci/pcie/Makefile > > @@ -6,10 +6,11 @@ > > obj-$(CONFIG_PCIEASPM) += aspm.o > > > > pcieportdrv-y := portdrv_core.o portdrv_pci.o portdrv_bus.o > > +pcieportdrv-$(CONFIG_ACPI) += portdrv_acpi.o > > > > obj-$(CONFIG_PCIEPORTBUS) += pcieportdrv.o > > > > # Build PCI Express AER if needed > > obj-$(CONFIG_PCIEAER) += aer/ > > > > -obj-$(CONFIG_PCIE_PME) += pme/ > > +obj-$(CONFIG_PCIE_PME) += pme/pcie_pme.o > > and > > > Index: linux-2.6/drivers/pci/pcie/pme/Makefile > > =================================================================== > > --- linux-2.6.orig/drivers/pci/pcie/pme/Makefile > > +++ /dev/null > > @@ -1,8 +0,0 @@ > > -# > > -# Makefile for PCI-Express Root Port PME signaling driver > > -# > > - > > -obj-$(CONFIG_PCIE_PME) += pmedriver.o > > - > > -pmedriver-objs := pcie_pme.o > > -pmedriver-$(CONFIG_ACPI) += pcie_pme_acpi.o > > $ make -j12 O=../gitbuild/ > GEN /home/seto/gitbuild/Makefile > CHK include/linux/version.h > Using /home/seto/GIT-linux as source for kernel > CHK include/generated/utsrelease.h > CALL /home/seto/GIT-linux/scripts/checksyscalls.sh > CHK include/generated/compile.h > CC drivers/pci/pcie/pme/pcie_pme.o > Assembler messages: > Fatal error: can't create drivers/pci/pcie/pme/.tmp_pcie_pme.o: No such file or directory > make[4]: *** [drivers/pci/pcie/pme/pcie_pme.o] Error 2 > make[3]: *** [drivers/pci/pcie] Error 2 > make[2]: *** [drivers/pci] Error 2 > make[1]: *** [drivers] Error 2 > make: *** [sub-make] Error 2 > $ > > It seems that the error is because directory pme/ is not created > in the working tree. Hmm. That seems to be correct, but I'm not sure how to resolve it. If I move pcie_pme.c to pcie/ in the same patch, the changes in that file will not be clearly visible. Perhaps I'll add a separate patch that will remove the Makefile from pme/ and move pcie_pme.c to pcie/. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html