On Wednesday, July 14, 2010 06:54:53 am yakui.zhao@xxxxxxxxx wrote:
> From: Zhao Yakui <yakui.zhao@xxxxxxxxx>
This should have a changelog saying *why* we need to export
pnp_bus_type.
I looked it up myself, and I see that the next patch adds
acpi_ipmi, which can be a module, and acpi_ipmi references
pnp_bus_type.
I don't like this exposure of pnp_bus_type. I don't think
drivers should be using it. I'll comment more in a response
to the next patch.
Bjorn
> Signed-off-by: Zhao Yakui <yakui.zhao@xxxxxxxxx>
> cc: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> ---
> drivers/pnp/driver.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/pnp/driver.c b/drivers/pnp/driver.c
> index cd11b11..9aec98a 100644
> --- a/drivers/pnp/driver.c
> +++ b/drivers/pnp/driver.c
> @@ -218,6 +218,8 @@ struct bus_type pnp_bus_type = {
> .dev_attrs = pnp_interface_attrs,
> };
>
> +EXPORT_SYMBOL(pnp_bus_type);
> +
> int pnp_register_driver(struct pnp_driver *drv)
> {
> drv->driver.name = drv->name;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
