Re: [patch for 2.6.34? 1/1] acpi: video: fix acpi_backlight=video

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 13 May 2010 12:33:57 am akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
>
> Make "acpi_backlight=video" param enable ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO
> as intended, instead of incorrectly enabling video output switching.
IIRC the only native driver which takes over backlight switching is panasonic,
because Len saw 2 brightness steps missing.
This one should have been solved by a "compatibility" patch from Rui and
this one could also use video.ko by default.

Still, this one is a safe fix.
Just in case someone wants to avoid the use of this boot param and get
things done right by default (and likes to send a patch for it :)).

      Thomas

> Addresses http://bugs.launchpad.net/bugs/573120
>
> Signed-off-by: Kamal Mostafa <kamal@xxxxxxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Cc: Zhang Rui <rui.zhang@xxxxxxxxx>
> Cc: Bjorn Helgaas <bjorn.helgaas@xxxxxx>
> Cc: Jiri Kosina <jkosina@xxxxxxx>
> Cc: <stable@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
>  drivers/acpi/video_detect.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video
> drivers/acpi/video_detect.c ---
> a/drivers/acpi/video_detect.c~acpi-video-fix-acpi_backlight=video +++
> a/drivers/acpi/video_detect.c
> @@ -250,7 +250,7 @@ static int __init acpi_backlight(char *s
>  				ACPI_VIDEO_BACKLIGHT_FORCE_VENDOR;
>  		if (!strcmp("video", str))
>  			acpi_video_support |=
> -				ACPI_VIDEO_OUTPUT_SWITCHING_FORCE_VIDEO;
> +				ACPI_VIDEO_BACKLIGHT_FORCE_VIDEO;
>  	}
>  	return 1;
>  }
> _
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux