On Tue, Apr 20, 2010 at 11:01:21PM +0800, Len Brown wrote:
Hmm, the mail is sent at Apr 20, I received it at Apr 29 :(
> wouldn't it be better for acpi_get_table()
> to return failure for acpi=off?
but acpi_disabled is a linux variable while acpi_get_table is ACPICA code.
Thanks,
Shaohua
>
> On Thu, 8 Apr 2010, Shaohua Li wrote:
>
> > acpi_hest_firmware_first_pci() could be called when acpi is disabled
> > and cause system oops.
> >
> > Signed-off-by: Shaohua Li <shaohua.li@xxxxxxxxx>
> > ---
> > drivers/acpi/hest.c | 4 ++++
> > 1 files changed, 4 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/acpi/hest.c b/drivers/acpi/hest.c
> > index 4bb18c9..1c527a1 100644
> > --- a/drivers/acpi/hest.c
> > +++ b/drivers/acpi/hest.c
> > @@ -123,6 +123,10 @@ int acpi_hest_firmware_first_pci(struct pci_dev *pci)
> > {
> > acpi_status status = AE_NOT_FOUND;
> > struct acpi_table_header *hest = NULL;
> > +
> > + if (acpi_disabled)
> > + return 0;
> > +
> > status = acpi_get_table(ACPI_SIG_HEST, 1, &hest);
> >
> > if (ACPI_SUCCESS(status)) {
> > --
> > 1.6.3.3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
