On Tue, Apr 27, 2010 at 01:12:49PM -0400, Len Brown wrote: > > When ACPI_PROCFS is disabled, /proc/acpi/fan/ directory is not created. > > So, it should not be removed during the module removal either. > > Yes, this patch would make the #ifdefs consistent. > But it looks like remove_proc_entry() just silently does nothing > if the directory is not there, yes? > No, I get a WARNING right now. That's why I hit the problem, I've just randomly removed fan. > What I'd really like to see is a patch removing fan.c's proc code > completely. It was scheduld for removal in July 2008. > Well, no config for "old fan /proc files"? Simply drop it? If that's OK, I'll gladly submit another patch. > thanks, > Len Brown, Intel Open Source Technology Center
Attachment:
signature.asc
Description: Digital signature
