On Thursday 22 April 2010 02:02:20 pm Dan Carpenter wrote: > On Thu, Apr 22, 2010 at 09:43:46PM +0200, Dan Carpenter wrote: > > This addresses: https://bugzilla.kernel.org/show_bug.cgi?id=14998 > > > > We copy some strings into "event" and kmemcheck complains that the bytes > > after the NULL terminators are uninitialized. That's true but it's > > harmless. The "event" struct is used in acpi_system_read_event() and we > > don't read past the terminator. > > > > This patch just silences the warning. > > > > Reported-by: Christian Casteyde <casteyde.christian@xxxxxxx> > > Signed-off-by: Dan Carpenter <error27@xxxxxxxxx> > > Tested-by: Christian Casteyde <casteyde.christian@xxxxxxx> > > > > diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c > > index 37132dc..4ef7c97 100644 > > --- a/drivers/acpi/bus.c > > +++ b/drivers/acpi/bus.c > > @@ -527,7 +527,7 @@ int acpi_bus_generate_proc_event4(const char *device_class, const char *bus_id, > > if (!event_is_open) > > return 0; > > > > - event = kmalloc(sizeof(struct acpi_bus_event), GFP_ATOMIC); > > + event = kmalloc(sizeof(struct acpi_bus_event), GFP_ATOMIC | __GFP_NOTRACK_FALSE_POSITIVE); Just in terms of reading the code, this solution is fairly ugly. I think __GFP_NOTRACK should be sort of the last resort, after we've ruled out all the more conventional strategies. Has anybody tried any of the alternatives Vegard suggested here: https://bugzilla.kernel.org/show_bug.cgi?id=14998#c35 ? Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
