thanks,
Len Brown, Intel Open Source Technology Center
On Mon, 22 Mar 2010, Chase Douglas wrote:
> From: Chase Douglas <chase.douglas@xxxxxxxxxxxxx>
>
> By default, ACPI resource conflict messages are logged at level
> KERN_ERR. This is a rather high level for a message that is more a
> warning than an indication of a real kernel error. Also, KERN_ERR level
> messages can appear over some boot splash screens, and this message is
> not serious enough to warrant such treatment. Thus, the log level has
> been reduced to KERN_INFO.
>
> Also, cleanup message to use %pR resource printing format.
>
> Signed-off-by: Chase Douglas <chase.douglas@xxxxxxxxxxxxx>
> ---
> drivers/acpi/osl.c | 14 ++++----------
> 1 files changed, 4 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/acpi/osl.c b/drivers/acpi/osl.c
> index 02e8464..33a01cb 100644
> --- a/drivers/acpi/osl.c
> +++ b/drivers/acpi/osl.c
> @@ -1151,16 +1151,10 @@ int acpi_check_resource_conflict(const struct resource *res)
>
> if (clash) {
> if (acpi_enforce_resources != ENFORCE_RESOURCES_NO) {
> - printk("%sACPI: %s resource %s [0x%llx-0x%llx]"
> - " conflicts with ACPI region %s"
> - " [0x%llx-0x%llx]\n",
> - acpi_enforce_resources == ENFORCE_RESOURCES_LAX
> - ? KERN_WARNING : KERN_ERR,
> - ioport ? "I/O" : "Memory", res->name,
> - (long long) res->start, (long long) res->end,
> - res_list_elem->name,
> - (long long) res_list_elem->start,
> - (long long) res_list_elem->end);
I think KERN_WARNING would be more appropriate here, as
this is a condition that may cause a devide driver to refuse to load...
I agree with skipping the check of acpi_enforce_resources here.
> + printk(KERN_INFO "ACPI: resource %s %pR"
> + " conflicts with ACPI region %s %pR\n",
> + res->name, res, res_list_elem->name,
> + res_list_elem);
> if (acpi_enforce_resources == ENFORCE_RESOURCES_LAX)
> printk(KERN_NOTICE "ACPI: This conflict may"
> " cause random problems and system"
> --
> 1.6.3.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
