Myron Stowe wrote: > Remove optional ACPI static Service Processor Management Interface > (SPMI) table based IPMI device discovery mechanism. Myron, The other patches look reasonable. This one, I'm not so sure. My concern is based on these thoughts: During early hardware bring-up, both ACPI and IPMI subsystems of a new system design tend to be a total mess. The static table parts of ACPI are likely to be usable much earlier than the parts that require a fully functional ACPI subsystem. For the people developing and testing the new system's IPMI subsystem, losing the SPMI discovery method could be a significant pain point. A new IPMI subsystem may also be "bolted on" to an existing system for early development before the new system is mature enough to even power on. In such a situation it may be easier to supply a fake table than fake live ACPI information. The hardware at that point may not be in PCI space, yet may also not be at static addresses that would be easy to supply as module load parameters. I would be more comfortable if you kept this code, perhaps suppressed under a "CONFIG_IPMI_SPMI" config option. >Bela<-- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
