Re: [PATCH 4/8] ACPI: Use GPE reference counting to support shared GPEs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday 25 February 2010, Alexey Starikovskiy wrote:
> Rafael J. Wysocki пишет:
> > --- linux-2.6.orig/drivers/acpi/ec.c
> > +++ linux-2.6/drivers/acpi/ec.c
> > @@ -307,7 +307,11 @@ static int acpi_ec_transaction(struct ac
> >  	pr_debug(PREFIX "transaction start\n");
> >  	/* disable GPE during transaction if storm is detected */
> >  	if (test_bit(EC_FLAGS_GPE_STORM, &ec->flags)) {
> > -		acpi_disable_gpe(NULL, ec->gpe);
> > +		/*
> > +		 * It has to be disabled at the hardware level regardless of the
> > +		 * GPE reference counting, so that it doesn't trigger.
> > +		 */
> > +		acpi_set_gpe(NULL, ec->gpe, ACPI_GPE_DISABLE);
> >  	}
> >   
> EC should have non-shared GPE, according to spec. Thus, refcounting is
> not needed here anyway.

So we can just use acpi_disable_gpe() here and analogously with enable
and in suspend/resume?

OK, I'll send a followup patch for that.

Rafael
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux