Re: [PATCH] ACPI video: Be more liberal in validating _BQC behaviour

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2010-02-22 at 10:06 +0800, Matthew Garrett wrote:
> On Mon, Feb 22, 2010 at 09:51:19AM +0800, Zhang Rui wrote:
> > On Fri, 2010-02-19 at 21:54 +0800, Matthew Garrett wrote:
> > > My system statically initialises the variable containing the current 
> > > brightness to 100, but doesn't include 100 in the list of valid 
> > > brightnesses.
> > 
> > sorry, I don't understand.
> > does the video driver set the backlight to 100, which is not a valid
> > value in the _BCL package?
> 
> No, the firmware does.
> 
> > >  Right now this causes us to stop believing _BQC. However, 
> > > the enxt thing we do is set the brightness to maximum anyway - at this 
> > > point _BQC will now return a correct value.
> > 
> > hmmm, could you attach the acpidump please?
> 
> The relevant bits are:
> 
>                     Name (BRIG, 0x64)
>                     Method (_BQC, 0, Serialized)
>                     {
>                         Store (BRIG, Local0)
>                         Return (Local0)
>                     }
>                     Method (_BCM, 1, Serialized)
>                     {
> 			...
>                         Store (Arg0, BRIG)
> 
> 0x64 is an invalid value as far as _BCL goes. So, _BQC will give an 
> invalid response until we set a value - after that, it'll be correct.
> 
hmmm, then this seems reasonable.
Acked-by: Zhang Rui <rui.zhang@xxxxxxxxx>

thanks,
rui


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux