On Mon, Feb 22, 2010 at 06:24:16PM +0100, Thomas Renninger wrote: > Can you use: > printk(KERN_WARNING FW_WARN "%s returned an invalid level", buf); > instead please. > It would be great if major kernel contributors, especially those working > near the BIOS do make use of the FW_* strings more often! I could, but I don't see there being any real benefit in doing so while the rest of the file doesn't make use of it. It seems like a reasonable thing to do in a followup patch. > Cleaning up existing messages is one (work intensive) thing, but please > use it to identify new BIOS issues. This is just moving an existing warning, rather than adding a new issue. -- Matthew Garrett | mjg59@xxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html