I think I'll just delete the dead acpi_evaluate_string() instead.
thanks for pointing it out,
Len Brown, Intel Open Source Technology Center
On Tue, 2 Feb 2010, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> From: Roel Kluin <roel.kluin@xxxxxxxxx>
>
> This always evaluates to true.
>
> It's between an #if 0 ... #endif.
>
> Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
> Cc: Len Brown <lenb@xxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> ---
>
> drivers/acpi/utils.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff -puN drivers/acpi/utils.c~acpi-fix-confusion-in-acpi_evaluate_string-in-comment drivers/acpi/utils.c
> --- a/drivers/acpi/utils.c~acpi-fix-confusion-in-acpi_evaluate_string-in-comment
> +++ a/drivers/acpi/utils.c
> @@ -312,7 +312,7 @@ acpi_evaluate_string(acpi_handle handle,
> element = (acpi_object *) buffer.pointer;
>
> if ((element->type != ACPI_TYPE_STRING)
> - || (element->type != ACPI_TYPE_BUFFER)
> + && (element->type != ACPI_TYPE_BUFFER)
> || !element->string.length) {
> acpi_util_eval_error(handle, pathname, AE_BAD_DATA);
> return AE_BAD_DATA;
> _
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
